Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add istio and preliminary ci #3

Merged
merged 17 commits into from
Oct 27, 2023
Merged

feat: Add istio and preliminary ci #3

merged 17 commits into from
Oct 27, 2023

Conversation

zachariahmiller
Copy link
Contributor

@zachariahmiller zachariahmiller commented Oct 27, 2023 •
edited
Loading

Description

Add istio and ci
...

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@zachariahmiller zachariahmiller changed the title Add istio and preliminary ci feat: Add istio and preliminary ci Oct 27, 2023
mikevanhemert
mikevanhemert previously requested changes Oct 27, 2023
View reviewed changes
zarf-runner/rusty-rogers/zarf.yaml Outdated Show resolved Hide resolved
MxNxPx
MxNxPx approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@MxNxPx MxNxPx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering the state of tooling we have today, this gets us something we can use now for istio and CI that we could really use atm. understanding that some of the things are just placeholders (like release & publish) which will be updated in follow up PRs. thanks @zachariahmiller!!

@zachariahmiller zachariahmiller dismissed mikevanhemert’s stale review October 27, 2023 22:50

we discussed synchronously and agreed to merge with the existing pattern that cant be made generic until we improve the task runner pattern

@zachariahmiller
Copy link
Contributor Author

I'm merging this with the two approvals.

For someone to add their capability to CI they will need to create the .github/zarf-runner things under their capabilities folder (temp while waiting for the taskrunner kind) and then go to .github/filters.yaml and add their capability like so:

`
istio:

  • 'capabilities/istio/**/*'
    neuvector:
  • 'capabilities/neuvector/**/*'
    example:
  • 'capabilities/example/**/*'
    `

@MxNxPx MxNxPx requested review from MxNxPx and mjnagel and removed request for mikevanhemert October 27, 2023 22:56
MxNxPx
MxNxPx approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@MxNxPx MxNxPx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@zachariahmiller zachariahmiller merged commit fbd7453 into main Oct 27, 2023
3 checks passed
@zachariahmiller zachariahmiller deleted the add_istio branch October 27, 2023 22:58
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy left review comments

@MxNxPx MxNxPx MxNxPx approved these changes

@mikevanhemert mikevanhemert mikevanhemert left review comments

@mjnagel mjnagel Awaiting requested review from mjnagel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zachariahmiller @jeff-mccoy @mjnagel @MxNxPx @mikevanhemert